Hi Martin, Thanks for initiating this effort of releasing it again.
On Sun, Jan 13, 2019 at 3:30 AM Martin Michlmayr <[email protected]> wrote: > * Martin Michlmayr <[email protected]> [2019-01-09 20:40]: > > * Balance checks and assignments: there were some fixes a few months ago, > > but since then a number of bugs have been reported. Did those fixes > break > > anything? Did we introduce regressions? Although now that I look, I > > cannot find these issues (but maybe I didn't look closely enough). Are > > things working right now or are there still issues? > > I am CCing the people who made changes in that area. > > Is everything working as it should now, or are there bugs that need to > be fixed (in particular regressions). > I had fixed some aspects of this, and also added a regression test ( https://github.com/ledger/ledger/blob/next/test/regress/1187_5.test) which still passes, so from my point of view, balances are working fine in all the cases I need. > > > * Run test suite on different platforms. The test suite passes for me on > > Debian stable. Can people on other platforms please build ledger from > > GitHub (next branch) and run the test suite and report back. > To validate them, I went through the instructions specified in the README.md file, and fixes a few things. See pull request #1716 <https://github.com/ledger/ledger/pull/1716>. It also makes it work with Python3 (and still with Python2!). My system: $ cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=18.04 DISTRIB_CODENAME=bionic DISTRIB_DESCRIPTION="Ubuntu 18.04.1 LTS" System is up-to-date as of 2019-01-13. Compilation now throws a few new warnings about fall through. I corrected these, see pull request #1717 <https://github.com/ledger/ledger/pull/1717>. Some tests fail though: 99% tests passed, 4 tests failed out of 371 Total Test time (real) = 11.80 sec The following tests FAILED: 21 - BaselineTest_cmd-convert (Failed) *26 - BaselineTest_cmd-org (Failed)* 119 - BaselineTest_opt-file (Failed) 258 - RegressTest_25A099C9 (Failed) Errors while running CTest Makefile:119: recipe for target 'test' failed make: *** [test] Error 8 #21, #119 and #258 seem related to the fact that the dir in which I ran the tests has some symbolic link portion, and the sourcepath that gets detected and replaced in the test output is wrong (even though it points at the same place). The cmd-org (#26) seems to be a genuine bug in the code, not the test framework, as the emitted table does not contain the same data at all. Hope any of this helps ! --paf > I haven't heard from anyone yet... > > TODO item I forgot to mention: > > * Update web site > > -- > Martin Michlmayr > https://www.cyrius.com/ > -- --- You received this message because you are subscribed to the Google Groups "Ledger" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
