Good to see I am thinking on the same lines as the experts :)
I suggested the optional run for the tests with the assumption that they could take a while on a large DB, so running them multiple times might not be desirable, especially if the admin has run them to confirm that the changes made are correct prior to triggering the upgrade.
David G On 11/02/14 09:41, Chris Travers wrote:
On Mon, Feb 10, 2014 at 6:00 AM, David Godfrey <[email protected] <mailto:[email protected]>> wrote:Perhaps rather than adding tests like this to the primary upgrade scripts, there should be a separate tool that does some consistency checks and reports that can be run from within the normal LedgerSMB UI, and a commandline.With 1.4, these are defined in a perl module (Upgrade_Tests.pm). There's no reason they then couldn't be called and run from a command-line tool, a UI, etc. Part of the reason of specifying that they are upgrade tests is that we want to be able to specify that relevant tests are run there that won't run on 1.3 or higher. So in theory, at least you could take the 1.4 Upgrade_Tests.pm, and build a UI around it (CLI, GUI, web app, etc) that would work to check for certain kinds of issues in 1.2, 1.3, 1.4, SQL-Ledger 2.8, etc.The tests could be run as simple go/nogo with an option to show details of any problems for each test. The upgrade scripts could then require that the tests have been run at least once since the last DB change and a state file (the go/nogo results) checked for issues that would be release blocking. If the tests have not been run recently, then force them to run anyway.I think the simple thing to do is to actually run the tests in that case. They have been moved aside anyway so they can be re-used and run at other times too.This provides the advantage of being able to test the DB at any time with ease. Regards David G On 10/02/14 21:49, Chris Travers wrote:Also note, we could add it to LedgerSMB::Upgrade_Tests for 1.4 too as a pre-upgrade test (could be done for 1.3 and 1.2 together). The only thing is that if we do that it would refuse to upgrade until the books are balanced so we'd want to think about that relatively carefully.-- Best Wishes,Chris Travers Efficito: Hosted Accounting and ERP. Robust and Flexible. No vendor lock-in. http://www.efficito.com/learn_more.shtml ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk _______________________________________________ Ledger-smb-devel mailing list [email protected] <mailto:[email protected]> https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk _______________________________________________ Ledger-smb-devel mailing list [email protected] <mailto:[email protected]> https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel -- Best Wishes, Chris TraversEfficito: Hosted Accounting and ERP. Robust and Flexible. No vendor lock-in.http://www.efficito.com/learn_more.shtml ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ Ledger-smb-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________ Ledger-smb-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
