On Thu, Jun 16, 2016 at 3:39 PM, Torsten Bronger <bron...@physik.rwth-aachen.de> wrote: > Hallöchen! > > Roman Lebedev writes: > >> This will allow to do *some* verification of the database XML's >> at the build time. Well, each time make is run. > > Thank your for your contribution! @seek: I merged Roman's changes > to master and pushed this into the branch xmllint. > > It adds value and doesn't break anyting except maybe badly-written > third-party tools. Moreover, I had normalized myself the database > already with an own one-off tool, making Roman's changeset much > smaller. So, a LGTM from me. > > Some questions: > > * Should the XSD/DTD files get the database version number in its > file name? Hm, now that i think about it, probably both DTD and XSD should be for each db version, yes..
> * Should the DTD get a valid URL as its name? It wouldn't probably hurt. But i *believe* that once you put such absolute address there, it probably should not be changed. So i'd think twice if you want to use lensfun.sourceforge.net there. > * Should this check be enabled by default when building/installing? This question is definitely not for me :) Based on my darktable experience, if something is not done during normal process (make all is normal process) - it will be forgotten and will not be done. So i think it should definitely be enabled by default. Or, alternatively, hook it up to make check, and advise to run it, but it is more fragile this way.. > Tschö, > Torsten. Roman. > -- > Torsten Bronger Jabber ID: torsten.bron...@jabber.rwth-aachen.de > > > ------------------------------------------------------------------------------ > What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic > patterns at an interface-level. Reveals which users, apps, and protocols are > consuming the most bandwidth. Provides multi-vendor support for NetFlow, > J-Flow, sFlow and other flows. Make informed decisions using capacity planning > reports. http://pubads.g.doubleclick.net/gampad/clk?id=1444514421&iu=/41014381 > _______________________________________________ > Lensfun-users mailing list > Lensfun-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/lensfun-users ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohomanageengine _______________________________________________ Lensfun-users mailing list Lensfun-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lensfun-users
