Hi,

When I use “lens correction” in Darktable with the latest mil-sigma.xml, it
does not identify “Sigma 19mm F/2.8 DN" lens, because the lens identifies
itself as “E 19mm f/2.8 DN”.

Could mil-sigma.xml be updated as follows? (i.e. “Sigma 19mm f/2.8 DN”
becomes “E 19mm f/2.8 DN”) With the following change, Darktable can finally
identify the lens.

This naming convention (“E” in place of “Sigma”) also appears in other
lenses (e.g. “E 30mm f/2.8” at the beginning of mil-sigma.xml), and indeed
the following update is inspired by that entry.

Thanks!

--- mil-sigma.xml    2017-04-30 15:36:12.490986468 +0800
+++ /usr/share/lensfun/version_1/mil-sigma.xml    2017-04-30
15:38:56.087438856 +0800
@@ -78,7 +78,8 @@
     <lens>
         <!-- Identifies itself at Sony cameras as “E 19mm F2.8”. -->
         <maker>Sigma</maker>
-        <model>Sigma 19mm f/2.8 DN</model>
+        <model>E 19mm f/2.8 DN</model>
+        <model lang="en">Sigma 19mm f/2.8 DN</model>
         <mount>Sony E</mount>
         <mount>Micro 4/3 System</mount>
         <cropfactor>1.534</cropfactor>


-- 
Cheers,
Siu On
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Lensfun-users mailing list
Lensfun-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lensfun-users

Reply via email to