On Thu, Jun 11, 2009 at 1:09 AM, Ville M. Vainio <[email protected]> wrote:
> > The problem I saw with @detect_urls.py is a bug caused by hashcache - > clones to @thin nodes (the root node) will cause the children to > multiply. > > Try having "@thin ~/foo.py", clone it, add child, restart. > > This should be easy to fix - we just shouldn't enter the read() code > if we are in a clone & have already read in the contents. This could > probably also be fixed in the read() method, but that's the wrong > place for it I agree. There are too many permutations and combinations of read code for this to be a good solution. I assume the fix would be to g.create_tree_at_vnode (that's the only "real" code that gets executed in the cashed-read logic). I would probably add a keyword param, say deleteOriginalTree, with a default value of False. It would set to True in the read logic. I might then add a wrapper to be called from all read code that sets this keyword to True. But you are free to do whatever you like. > (I think there is some workaround for this problem in the > "slow" read code now, but that workaround should not be necessary). Yes. createThinChild4 and findFind4 are were the bodies are buried. I don't remember the details, but you can see the code is ugly. Edward --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~----------~----~----~----~------~----~------~--~---
