What's weird is that I don't see any comment or commit for the changes that I found. Not in my repo or Leo's. Anyway, I reverted the changes and added a better way to accomplish the same thing. I have put in a pull request for this version.
On Saturday, August 22, 2020 at 2:14:34 PM UTC-4, Thomas Passin wrote: > > It looks like the changes to vr3 came via a change in the devel branch, > and those must have come from leo-editor's devel branch. So it probably > wasn't someone changing my repo directly. Still, there should have been > some discussion somewhere first. > > On Saturday, August 22, 2020 at 1:31:00 PM UTC-4, Thomas Passin wrote: >> >> As long as we're on the subject, someone made some changes to >> viewrendered3 *in my github repo* that I didn't know about. There is a >> syntax error in these changes, and I *think* something else got >> inadvertently changed, and I will have to fix that up, too. Now if they >> had put in a PR, it would have been better. >> >> BTW, how do I activate the "Issues" tab in github? At least we'd have a >> place to discuss prospective changes like this. >> >> I think it's not thoughtful to go ahead and make changes to someone >> else's development repo without discussing them first. Please don't do >> that. >> >> -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/6b862eb5-9465-41e6-a708-9074b3b7ab8eo%40googlegroups.com.
