Not all imports come from a git repo.  I would say that the majority of 
mine (historically) have come from previously existing files on my system 
that will never get into a repo.   I think it is unwise to depend on some 
external program to detect Leo-specific errors.

On Wednesday, July 27, 2022 at 10:32:31 AM UTC-4 Edward K. Ream wrote:

> On Monday, July 25, 2022 at 7:28:17 AM UTC-5 Edward K. Ream wrote:
>
> P.S. I may alter Vitalije's importer slightly. At present, Vitalije's 
>> importer carefully adds Leo's escape string for underindented lines. Imo, 
>> it may be better *not *to add those escapes, even if Leo does not import 
>> some (strange!) files properly. Tweaking imported files is to be expected. 
>> Users can always use git to correct import problems.
>>
>
> *Aha: What did I just say?!?* If we are going to rely on git to report 
> importer problems then the Importer class need not do so!! The Importer 
> class suddenly loses a lots of ugly code! Simplified "perfect import" 
> checks can migrate to unit tests.
>
> Furthermore, Vitalije's approach does not require a post-pass. And even if 
> it did, the clumsy post-pass API can go away.  Hurray!
>
> *Summary*
>
> The Importer class is about to collapse in complexity! 
>
> Edward
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/02e7dc4e-3124-49d1-976f-78cd2f4796ffn%40googlegroups.com.

Reply via email to