Hello Edward,

Edward K. Ream schrieb am Freitag, 11. April 2025 um 20:08:30 UTC+2:

On Fri, Apr 11, 2025 at 12:14 PM Viktor Ransmayr 

> PR #4237 <https://github.com/leo-editor/leo-editor/pull/4237/files> 
summarizes all changes between version 6.8.3 and Leo's 6.8.4 branch.
> The changes you see in coloring are likely due to new settings in 
leoSettings.leo:
...
> Reading parts of PR #4237 
<https://github.com/leo-editor/leo-editor/pull/4237/files> I have the 
feeling that too many branches are involved ... 

I wasn't as helpful as I could have been.

This page 
<https://github.com/leo-editor/leo-editor/pulls?q=is%3Apr+milestone%3A6.8.4+is%3Aclosed>
 
lists all the closed PRs in Leo 6.8.4. Scanning down the list of PRs we see 
PR #4281 <https://github.com/leo-editor/leo-editor/pull/4281>:
Allow rest comments to be colored differently from @language rest.

> I tried to find "rest.literal" in 'leoSettings' outline of the 'devel' 
branch - but - failed :-(

The valid settings are @color rest.literal1 through @color rest.literal4.

Aha! You have found a compatibility bug! leoSettings defines two new 
settings as True:

@bool color-doc-parts-as-rest = True
@bool color-docstrings-as-rest = True

But these *must* have defaults of False to ensure legacy coloring does not 
change.

Many thanks for pointing out this serious bug.  

PR #4328 <https://github.com/leo-editor/leo-editor/pull/4328> sets both 
these settings to False. Please test and let me know your results.

This PR is a draft. There may be more work to do. My tests don't show the 
same results as your screen shots, but that may be a result of different 
settings in my copy of myLeoSettings.leo.


 The issue persists ! - For the moment I tried everything I could think of 
w/o success ...

Here's my log:

###

Update PyVE for Leo from GitHub to current state of Leo's repository - OK - 
See "Log-001".

Switch to the 'ekr-rest-coloring2' branch & re-open this outline using the 
updated PyVE - OK? - See "Log-002".

* Answer: NO - Coloring issue still exists :-(

Open 'leoSettings.leo' & check status of the two settings ?

* Result: The two settings are correct, i.e., set to 'false' !

Open 'myLeoSettings.leo' & check '@enabled-plugins' ?

* Switch from 'viewrendered3.py' to 'viewrendered.py' & re-open this 
outline - OK? - See "Log-003".

    * Answer: NO - Coloring issue still exists :-(

* Comment out all rst3-related settings in 'myLeoSettings.leo' & re-open 
this outline - OK? - See "Log-004".

    * Answer: NO - Coloring issue still exists :-(

Re-open this outline using the PyVE with Leo 6.8.3 - OK - See "Log-005".

* Answer: YES - Coloring issue does not exist ...

**Report results & take a break ;-)**

###

Please let me know, if you have any other suggestions I should try out !

With kind regards,

Viktor

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/leo-editor/36fe45e6-3e6a-4a2b-8ed3-d4beda088261n%40googlegroups.com.

Reply via email to