DJ Lucas wrote:
> Mostly for Bruce, but sent to list for everyone's review:
>
> Attached are some fixes for the bootscripts. These are mostly cosmetic,
> but there are some minor functional changes due in part to reverting to
> multi-part writes to the screen, some clean-up/simplification of syntax,
> for instance, == instead of = in comparison tests, use "-a" and "-o"
> instead of "] && [" or "] || [" resp., removed the second interactive
> prompt, made available boot message prefixes and color ${INFO} for
> mountvirtfs, made certain that control charcters are not written to the
> boot log in case color codes are used in screen messages, and reduced
> duplication of items in rc.site and init-functions (rc.site is required
> for init-functions/rc). Please review, and discuss if necessary, before
> commit.
I appreciate the fixes. I'll review the diff in more detail, but note
that I used = instead of == for string comparisons explicitly because
the bash man page says:
string1 == string2
True if the strings are equal. = may be used in place of == for
strict POSIX compliance.
I was trying to make the scripts Bourne/Posix compatible.
-- Bruce
--
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page
