On Thu, May 14, 2020 at 08:53:18AM -0500, Douglas R. Reno via lfs-dev wrote: > > On 5/14/20 1:33 AM, Xi Ruoyao via lfs-dev wrote: > > On 2020-05-13 23:46 -0500, Bruce Dubbs via lfs-dev wrote: > > > On 5/13/20 11:33 PM, Ken Moffat via lfs-dev wrote: > > > > I notice that in some places people have overridden any existing > > > > CFLAGS when adding -fcommon. In most places, for those of us who > > > > care the fix is obvious (CFLAGS="$CFLAGS -fcommon"). One or two > > > > packages will turn out to be more painful. > > > >
> > > > Can I ask people to at least *consider* not trashing a user's > > > > specified CFLAGS ? > > > Yes, we can do that, but right now we are trying to just get everything > > > to build with gcc10. When that is done, we can probably review and do > > > 'grep -r CFLAGS; in the book's xml top and do the right thing where we > > > have had to make changes. > > > No problem with prioritising getting the packages to build, but one or two (a couple of the video drivers) already pick up the CFLAGS before adding -fcommon. > > > Also as new package releases address gcc10, we can probably remove a lot > > > of the CFLAGS entries that we've been making. > > I don't like -fcommon. It's actually changing C semantics. The correct > > thing > > to do is to fix the code (like what we do for gdbm in LFS). > > > > Though we can simply add this workaround for now... > > Agreed here, I don't like it either. Most of these would be very simple > fixes and may even be accomodated via sed instead of patch. > > That's OK though, I'll go with what everyone else is doing for now... > I've seen a comment from a fedora developer that he had to spend a lot of time getting everything to build with gcc-10. I'm sure some of what they build is development versions, and they ignore some other things we build, but fedora might be a place worth looking. ĸen -- See You Later, Holy Poppadom! -- Red Dwarf, The Promised Land -- http://lists.linuxfromscratch.org/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page