On March 25, 2017 21:56:35 Bruce Dubbs <bruce.du...@gmail.com> wrote:
Tim Tassonis wrote:
On March 25, 2017 17:03:33 "Michael D. L." <lfs-supp...@cosis.dk> wrote:
> On 03/25/2017 04:01 PM, Tim Tassonis wrote:
>> Hi again
>>
>>
>> On my full lfs 8.0 rebuild, I have built shadow 4.4 as specified on
>> the lfs page, however I did it the "blfs way" of first installing pam.
>>
>>
>> When building shadow, I got the following error:
>>
>> su.c:376:3: error: too few arguments to function 'snprintf'
>> snprintf (kill_msg, _(" ...killed.\n"));
>> ^~~~~~~~
>>
>>
>> In blfs, there is following sed to prevent this:
>>
>> sed -i -e '/snprintf/s@_msg,@_msg, 256,@' src/su.c &&
>>
>>
>> Is this error only happening due to pam being used or should this sed
>> be included in the plain lfs instructions of shadow as well?
>>
>>
>> Cheers
>> Tim
> Hi Tim,
>
> If you look at the "Command Explanations" section of the Shadow-4.4
> page, you'll see:
>
> *sed -i -e '/snprintf/s@_msg,@_msg, 256,@' src/su.c*: Fix a build error
> that only occurs if Linux-PAM-1.3.0
> <http://www.linuxfromscratch.org/blfs/view/stable/postlfs/linux-pam.html>
> is detected by *configure*.
>
> So it's only if PAM is installed that the sed command required.
Thanks for the hint, missed that line.
>
> Also, you shouldn't deviate from the LFS build order - it'll only get
> you in trouble ;)
Don't worry, this is my 4th full build, I dare to claim that I generally
know what I'm doing when I deviate. Building pam (and libtirpc) before
shadow is quite a common deviation for people who want to use pam.
Tim, Of course it is your distro and your rules. However, I would like to
point out that the LFS and BLFS books have been tested reasonably well and
the order of things is important.
In BLFS, we reinstall shadow after PAM. What you are doing is avoiding a
single package that has a build/install time of 0.2 SBU. The reason we
defer PAM to BLFS is because there are several optional dependencies that
users my want. Is that 0.2 SBU time saving worth the extra hassle?
Hi Bruce
The first time a few years ago I did exactly that and then asked on the
list about the possible shortcut and got the answer that this is no
problem. I have since then successfully build full lfs twice with pam
before shadow without any problems. The only reason for my post was just to
ask if maybe there was an error on the shadow page regarding su. I was told
that I unfortunately overread the line on the page exactly telling about
this. In no way I wanted to steal anybody's time about my way of building
lfs. Sorry for the noise.
Cheers
Tim
-- Bruce
--
http://lists.linuxfromscratch.org/listinfo/lfs-support
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
Do not top post on this list.
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
http://en.wikipedia.org/wiki/Posting_style
--
http://lists.linuxfromscratch.org/listinfo/lfs-support
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
Do not top post on this list.
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
http://en.wikipedia.org/wiki/Posting_style
