On Thu, Apr 18, 2002 at 11:27:43AM +0400, Alexander V. Lukyanov wrote:
> > Job.h: Make SetParentFg also Bg the job if the parent is Bg'd; in other
> > words, make it always copy the fg/bg state from the parent, not
> > just if the parent is Fg'd.
> 
> Did you mean:
> 
> --- Job.h     2002/01/21 16:25:15     1.17
> +++ Job.h     2002/04/17 20:10:39
> @@ -61,8 +61,10 @@
>     void SetParentFg(Job *j, bool f=true)
>        {
>        SetParent(j);
> -      if(j->fg && f)
> +      if(f && j->fg)
>           Fg();
> +      else if(!f || !j->fg)
> +         Bg();
>        }

No; I read that "f=true" as "if true, apply the new parent's Fg status
to the job".  I've looked at every call to this function, and I can't
figure out why I did this--every call to it (where f=true) is made immediately
after a job is created, where this makes no difference.  Forget this for
now.

-- 
Glenn Maynard

Reply via email to