Hello,

the next Debian release will have enabled security hardening options in
most packages:

https://wiki.debian.org/Hardening
https://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags

When trying to build lftp the linking fails with the following error:

/bin/bash ../libtool --silent --tag=CXX   --mode=compile gcc -DHAVE_CONFIG_H 
-I. -I../lib -I../lib -I../trio  -I/usr/include/p11-kit-1    
-D_FORTIFY_SOURCE=2  -g -O2 -fstack-protector --param=ssp-buffer-size=4 
-Wformat -Wformat-security -Werror=format-security -g -Wall -Wall 
-Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti 
-fno-implement-inlines -MT LocalAccess.lo -MD -MP -MF .deps/LocalAccess.Tpo -c 
-o LocalAccess.lo LocalAccess.cc
mv -f .deps/LocalAccess.Tpo .deps/LocalAccess.Plo
/bin/bash ../libtool --silent --tag=CXX   --mode=link gcc  -g -O2 
-fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security 
-Werror=format-security -g -Wall -Wall -Wwrite-strings -Woverloaded-virtual 
-fno-exceptions -fno-rtti -fno-implement-inlines -module -avoid-version -rpath 
/usr/lib/lftp/4.3.5 -Wl,-z,relro -o proto-file.la  LocalAccess.lo  -lutil 
-ltinfo -ldl -lsupc++ 
/bin/bash ../libtool --silent --tag=CXX   --mode=compile gcc -DHAVE_CONFIG_H 
-I. -I../lib -I../lib -I../trio  -I/usr/include/p11-kit-1    
-D_FORTIFY_SOURCE=2  -g -O2 -fstack-protector --param=ssp-buffer-size=4 
-Wformat -Wformat-security -Werror=format-security -g -Wall -Wall 
-Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti 
-fno-implement-inlines -MT Fish.lo -MD -MP -MF .deps/Fish.Tpo -c -o Fish.lo 
Fish.cc
Fish.cc: In member function 'int Fish::HandleReplies()':
Fish.cc:567:18: error: format not a string literal and no format arguments 
[-Werror=format-security]
cc1plus: some warnings being treated as errors
make[2]: *** [Fish.lo] Error 1
make[2]: Leaving directory `/tmp/buildd/lftp-4.3.5/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/buildd/lftp-4.3.5'
make: *** [build-stamp] Error 2

This is the configure command with the (flags expanded from variables):

CFLAGS="-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat
-Wformat-security -Werror=format-security -g -Wall" \
CXXFLAGS="-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat
-Wformat-security -Werror=format-security -g -Wall" \
CPPFLAGS="-D_FORTIFY_SOURCE=2" \
LDFLAGS="-Wl,-z,relro" ./configure \
                        --prefix=/usr \
                        --mandir=\${prefix}/share/man \
                        --infodir=\${prefix}/share/info \
                        --sysconfdir=/etc \
                        --with-pager=/etc/alternatives/pager

With out the hardening flags building is fine.
Can you reproduce the problem?

-- 
Noël Köthe <noel debian.org>
Debian GNU/Linux, www.debian.org

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
lftp mailing list
lftp@uniyar.ac.ru
http://univ.uniyar.ac.ru/mailman/listinfo/lftp

Reply via email to