On Wed, 23 Mar 2011, Måns Rullgård wrote:
> Martin Storsjö <mar...@martin.st> writes:
>
> > On Wed, 23 Mar 2011, Måns Rullgård wrote:
> >
> >> Martin Storsjö <mar...@martin.st> writes:
> >>
> >> > The filtering of ASFLAGS is required since the symbian toolchain
> >> > requires a --include parameter in extra_cflags, which shouldn't
> >> > be passed on to ASFLAGS. The $(echo) surrounding the filtering
> >> > is needed since the output from filter_out contains linebreaks
> >> > between each parameter.
> >> > ---
> >> > configure | 8 +++++++-
> >> > 1 files changed, 7 insertions(+), 1 deletions(-)
> >> >
> >> > diff --git a/configure b/configure
> >> > index 00aa9ed..14ef220 100755
> >> > --- a/configure
> >> > +++ b/configure
> >> > @@ -1824,7 +1824,7 @@ set_default host_cc
> >> >
> >> > exesuf() {
> >> > case $1 in
> >> > - mingw32*|cygwin*|*-dos|freedos|opendos|os/2*) echo .exe ;;
> >> > + mingw32*|cygwin*|*-dos|freedos|opendos|os/2*|symbian) echo .exe
> >> > ;;
> >> > esac
> >> > }
> >> >
> >> > @@ -2487,6 +2487,12 @@ case $target_os in
> >> > add_cppflags -D_QNX_SOURCE
> >> > network_extralibs="-lsocket"
> >> > ;;
> >> > + symbian)
> >> > + SLIBSUF=".dll"
> >> > + disable ffserver
> >>
> >> Why does ffserver need to be explicitly disabled? If it fails to build,
> >> there is a missing check somewhere.
> >
> > Indeed - sent a patchset fixing this.
> >
> >> > + enable dos_paths
> >> > + ASFLAGS=$(echo $(filter_out --include* $ASFLAGS))
> >>
> >> filter_asflags="filter_out --include*"
> >
> > Ah yes - I tried that initially, but this is past the section where cflags
> > are added to ASFLAGS ("add_asflags $extra_cflags", quite soon after the
> > compiler detection section) - setting filter_asflags here doesn't have any
> > effect.
> >
> > Do you prefer moving part this up a bit, as a separate block, next to the
> > compiler section? Something like this:
> >
> > if [ "$target_os = "symbian" ]; then
> > filter_asflags="filter_out --include*"
> > endif
>
> No, that's worse. Bother me about it later today, I'll try to think of
> a nice solution.
Ping - any better suggestion?
// Martin
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
