Hi,

On Mon, Apr 11, 2011 at 10:01 AM, Luca Barbato <lu_z...@gentoo.org> wrote:
> On 04/11/2011 03:44 PM, Ronald S. Bultje wrote:
>> This isn't right. You're declaring empty functions for stuff that is
>> supposed to do something. In x86/yuv2rgb_mmx.c, you'll see these
>> functions are only called under if (HAVE_7REGS) anyway, so the proper
>> fix is to not declare these functions at all, i.e. move the #if
>> HAVE_7REGS outside the function declaration. Dead code elimination
>> should take care of the rest.
>
> The cleanup should take care of it.

That's still no reason to apply a broken patch before that... But
anyway, let's not take this too far, let's get your cleanup in, that's
much more exciting, and then let's fix whatever's left after.

Ronald
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to