On Apr 11, 2011, at 5:26 AM, Kostya wrote:
> On Mon, Apr 11, 2011 at 11:07:39AM +0200, Luca Barbato wrote:
>> With this commit we should have all the arch specific code moved away.
>> Init pattern now:
>> - generic C init first
>> - arch specific init later overwriting
>>
>> In future the arch specific init will overwrite just the generics for
>> which we have an optimization.
>> [..]
>
>> +void rgb2rgb_init_x86(int flags);
>
> is that requirement by modern GCC to declare function before its
> implementation in the same file?
Requirement of the compiler flags (-Werror=missing-prototypes).
If it's only used in this file it should be static.
>
>> +void rgb2rgb_init_x86(int flags)
>> +{
>> +
>> +#if HAVE_MMX2 || HAVE_AMD3DNOW || HAVE_MMX
>> + if (flags & SWS_CPU_CAPS_SSE2)
>> + rgb2rgb_init_SSE2();
>> + else if (flags & SWS_CPU_CAPS_MMX2)
>> + rgb2rgb_init_MMX2();
>> + else if (flags & SWS_CPU_CAPS_3DNOW)
>> + rgb2rgb_init_3DNOW();
>> + else if (flags & SWS_CPU_CAPS_MMX)
>> + rgb2rgb_init_MMX();
>> +#endif /* HAVE_MMX2 || HAVE_AMD3DNOW || HAVE_MMX */
>> +}
>> --
>> 1.7.4.1
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
