On 04/14/2011 11:01 PM, Stefano Sabatini wrote:
> On date Thursday 2011-04-14 22:50:40 +0200, Diego Biurrun wrote:
>> On Thu, Apr 14, 2011 at 10:43:50PM +0200, Stefano Sabatini wrote:
>>> On date Thursday 2011-04-14 22:12:36 +0200, Luca Barbato wrote:
>>>> MMX is always built. Drop the ifdefs
>>>> ---
>>>> libswscale/x86/rgb2rgb.c | 3 -
>>>> libswscale/x86/rgb2rgb_template.c | 300
>>>> +------------------------------------
>>>> 2 files changed, 1 insertions(+), 302 deletions(-)
>>>
>>> Highly uninformative message for a committ removing 300 lines of code.
>>
>> Well, I think we have already improved in the log message quality
>> department, but I agree there sure is still a way to go.
>>
>> This should likely better have been folded into one of the other
>> patches - hindsight is striking back ..
>>
>>> Also how if the #ifdef HAVE_BIGENDIAN removal related?
>>
>
>> x86 is little-endian, so the big-endian case has no place in the
>> directory for x86 code.
>
> Ah OK, so I suppose the same is for the other #ifdef ARCH_ALPHA &&
> HAVE_MVI etc. A mention in the log may be useful.
I'm thinking about adding a note along those lines
Notes:
x86 is little endian only, thus the big endian code can be removed.
All the optimized code assumes MMX presence so those conditions
are always true.
Stray non x86 code is removed as well.
lu
--
Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
