Hi, On Fri, Apr 22, 2011 at 11:34 AM, Anton Khirnov <an...@khirnov.net> wrote: > On Wed, 20 Apr 2011 18:08:17 -0400, "Ronald S. Bultje" <rsbul...@gmail.com> > wrote: >> Hi, >> >> On Wed, Apr 20, 2011 at 3:45 PM, Anton Khirnov <an...@khirnov.net> wrote: >> > From: Michael Niedermayer <michae...@gmx.at> >> > >> > Signed-off-by: Michael Niedermayer <michae...@gmx.at> >> > Signed-off-by: Anton Khirnov <an...@khirnov.net> >> > --- >> > libavfilter/vf_drawtext.c | 5 ++--- >> > 1 files changed, 2 insertions(+), 3 deletions(-) >> > >> > diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c >> > index 9fc0341..5eb14df 100644 >> > --- a/libavfilter/vf_drawtext.c >> > +++ b/libavfilter/vf_drawtext.c >> > @@ -389,9 +389,8 @@ static int config_input(AVFilterLink *inlink) >> > chroma_pos2 = ((x) >> (hsub)) + ((y) >> (vsub)) * picref->linesize[2]; >> > \ >> > alpha = (yuva_color[3] * (val)) / 255; \ >> > picref->data[0][luma_pos] = (alpha * yuva_color[0] + (255 - alpha) * >> > picref->data[0][luma_pos]) >> 8; \ >> > - alpha = (yuva_color[3] * (val)) / 224; \ >> > - picref->data[1][chroma_pos1] = (alpha * yuva_color[1] + (224 - alpha) >> > * picref->data[1][chroma_pos1]) / 224; \ >> > - picref->data[2][chroma_pos2] = (alpha * yuva_color[2] + (224 - alpha) >> > * picref->data[2][chroma_pos2]) / 224; \ >> > + picref->data[1][chroma_pos1] = (alpha * yuva_color[1] + (255 - alpha) >> > * picref->data[1][chroma_pos1]) >> 8; \ >> > + picref->data[2][chroma_pos2] = (alpha * yuva_color[2] + (255 - alpha) >> > * picref->data[2][chroma_pos2]) >> 8; \ >> >> Should be merged with 2. And is this actually correct? I don't think >> it is, unless this is 255-range YUV. > > No idea, I don't know how those things work ;) > Please fix if you do.
The math is fine, so patch OK. Ronald _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
