On date Wednesday 2011-05-11 07:39:07 +0200, Kostya encoded:
> On Mon, May 09, 2011 at 12:51:24PM +0200, Stefano Sabatini wrote:
> > Also add support for bits per component storage.
> >
> > Fix decoding of file 11.tiff, trac issue number #167.
> >
> > Based on a patch by Kostya Shishkov <kostya.shish...@gmail.com>.
> > ---
> > libavcodec/tiff.c | 138
> > ++++++++++++++++++++++++++++-------------------------
> > 1 files changed, 73 insertions(+), 65 deletions(-)
>
> Personally I don't understand that patch - why it assigns new meaning to bpp,
> why it saves all bits per component (I don't see it being used elsewhere) and
> what it does beside that.
I'm trying to handle the cases:
1) BitsPerSample = { 8, 8, 8 }, SamplesPerPixel unspecifid
If SamplesPerPixel is unspecified, the number of components is based on
the number of components specified in the BitsPerSample tag.
File b.tif, FFmpeg trac issue #168.
2) BitsPerSample = { 8 }, SamplesPerPixel = 3
File 11.tiff, FFmpeg trac issue #167.
In both cases totalbpp is computed with:
s->totalbpp = 0;
for (i = 0; i < s->bppcount; i++)
s->totalbpp += s->bpp[i] ? s->bpp[i] : s->bpp[0];
which issues the correct value in both cases.
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
