On Mon, 9 May 2011, Ronald S. Bultje wrote:
> On Mon, May 9, 2011 at 1:29 PM, Martin Storsjö <mar...@martin.st> wrote:
> > This is more like what VLC does. If the server doesn't mention
> > supporting GET_PARAMETER in response to an OPTIONS request,
> > VLC doesn't send any keepalive requests at all. After this patch,
> > libavformat will still send OPTIONS keepalives if GET_PARAMETER
> > isn't explicitly said to be supported.
> >
> > Some RTSP cameras don't support GET_PARAMETER, and will
> > close the connection if this is sent as keepalive request
> > (but support OPTIONS just fine, but probably don't need any
> > keepalive at all). Some other cameras don't support using
> > OPTIONS as keepalive, but require GET_PARAMETER instead.
> > ---
> >
> > This is an attempt to solve the issue reported at
> > https://ffmpeg.org/trac/ffmpeg/ticket/129. It still is
> > pending testing both by the reporter of that issue,
> > and by Tim Ouellette, to make sure it doesn't break
> > his streams.
> >
> > libavformat/rtsp.c | 4 ++++
> > libavformat/rtsp.h | 5 +++++
> > libavformat/rtspdec.c | 4 +++-
> > 3 files changed, 12 insertions(+), 1 deletions(-)
>
> Patch looks good, thanks.
Pushed.
Didn't hear back from Tim yet, but as far as I can see from the stream
dumps he sent when he reported the issue, this shouldn't change the
behaviour in his case.
// Martin
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
