Diego Biurrun <di...@biurrun.de> writes:

> Adding _POSIX_C_SOURCE to CPPFLAGS globally produces all sorts of problems
> since it causes certain system functions to be hidden on some (BSD) systems.
> The solution is to only add the flag on systems that really require it, i.e.
> glibc-based ones.
>
> This change makes BSD systems compile out-of-the-box without the need for
> adding specific flags manually.  It also allows dropping a number of flags
> set manually on a file-per-file basis, but were only present to work around
> breakage introduced by the presence of _POSIX_C_SOURCE.
>
> Also add _XOPEN_SOURCE to CPPFLAGS for glibc systems.  We use XSI extensions
> in several places already, so it is preferable to define it globally instead
> of littering source files with individual #defines only needed for glibc.
> ---
>  configure                    |    6 +++---
>  doc/general.texi             |    8 --------
>  ffmpeg.c                     |    3 ---
>  ffplay.c                     |    2 --
>  ffserver.c                   |    2 --
>  libavcodec/libxvidff.c       |    3 ---
>  libavdevice/bktr.c           |    4 ----
>  libavdevice/x11grab.c        |    2 --
>  libavformat/applehttp.c      |    1 -
>  libavformat/applehttpproto.c |    1 -
>  libavformat/avio.c           |    3 +--
>  libavformat/os_support.c     |    1 -
>  libavformat/rtpdec.c         |    3 ---
>  libavformat/udp.c            |    2 +-
>  libavutil/ppc/cpu.c          |    2 --
>  libswscale/utils.c           |    2 --
>  16 files changed, 5 insertions(+), 40 deletions(-)

Looks good to me.

-- 
Måns Rullgård
m...@mansr.com
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to