On Tue, May 17, 2011 at 01:59:43PM -0400, Ronald S. Bultje wrote:
>
> On Tue, May 17, 2011 at 1:57 PM, Diego Biurrun <di...@biurrun.de> wrote:
> > On Tue, May 17, 2011 at 06:37:58PM +0100, Måns Rullgård wrote:
> >> Diego Biurrun <di...@biurrun.de> writes:
> >>
> >> >> --- /dev/null
> >> >> +++ b/libavcodec/mpadsp.h
> >> >> @@ -0,0 +1,63 @@
> >> >> +
> >> >> +#ifndef AVCODEC_MPADSP_H
> >> >> +#define AVCODEC_MPADSP_H
> >> >> +
> >> >> +#include <stdint.h>
> >> >> +
> >> >> +typedef struct MPADSPContext {
> >> >> + void (*apply_window_float)(float *synth_buf, float *window,
> >> >> + int *dither_state, float *samples, int
> >> >> incr);
> >> >> + void (*apply_window_fixed)(int32_t *synth_buf, int32_t *window,
> >> >> + int *dither_state, int16_t *samples,
> >> >> int incr);
> >> >> + void (*dct32_float)(float *dst, const float *src);
> >> >> + void (*dct32_fixed)(int *dst, const int *src);
> >> >> +} MPADSPContext;
> >> >
> >> > unrelated comment: Will we keep typedeffing structs forever?
> >>
> >> Somehow I suspect you would have asked me to add the typedef (for
> >> consistency) had I left it out.
> >
> > No. However, the API breakage season is drawing to a close, so there
> > is not much time left to discuss such questions.
>
> This is not public API, is it?
The point I was trying to raise here is that some people (here) consider
typedeffing structs ugly. Some typedeffed structs are part of the public
API.
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
