On Wed, 18 May 2011, Diego Biurrun wrote:
> On Wed, May 18, 2011 at 04:21:48PM +0300, Martin Storsjö wrote:
> > From: Juan Carlos Rodriguez <[email protected]>
> >
> > --- a/libavformat/rtpenc.h
> > +++ b/libavformat/rtpenc.h
> > @@ -65,6 +65,7 @@ void ff_rtp_send_data(AVFormatContext *s1, const uint8_t
> > *buf1, int len, int m);
> > void ff_rtp_send_h264(AVFormatContext *s1, const uint8_t *buf1, int size);
> > void ff_rtp_send_h263(AVFormatContext *s1, const uint8_t *buf1, int size);
> > void ff_rtp_send_aac(AVFormatContext *s1, const uint8_t *buff, int size);
> > +void ff_rtp_send_latm(AVFormatContext *s1, const uint8_t *buff, int size);
> > void ff_rtp_send_amr(AVFormatContext *s1, const uint8_t *buff, int size);
> > void ff_rtp_send_mpegvideo(AVFormatContext *s1, const uint8_t *buf1, int
> > size);
> > void ff_rtp_send_xiph(AVFormatContext *s1, const uint8_t *buff, int size);
>
> This appears to have previously been in alphabetical order.
Nope, they're just piled up in kinda chronological order. This one
probably was placed here since it's related to the aac one above it.
> > --- /dev/null
> > +++ b/libavformat/rtpenc_latm.c
> > @@ -0,0 +1,60 @@
> > +/*
> > + * RTP Packetization of MPEG-4 Audio (RFC 3016)
> > + * Copyright (c) 2011 Juan Carlos Rodriguez
> > <[email protected]>
> > + *
> > + * This file is part of FFmpeg.
>
> Ummm...
Fixed locally
> > +void ff_rtp_send_latm(AVFormatContext *s1, const uint8_t *buff, int size) {
> > +}
>
> New files should be in K&R style, so please move the '{' to the
> next line.
Fixed
> > --- a/libavformat/sdp.c
> > +++ b/libavformat/sdp.c
> > @@ -299,6 +300,69 @@ xiph_fail:
> >
> > +static int latm_context2profilelevel(AVCodecContext *c) {
> > +}
> > +
> > +static char *latm_context2config(AVCodecContext *c) {
> > +}
>
> ditto
Fixed
// Martin_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
