On 05/23/2011 09:24 PM, Alex Converse wrote: > On Mon, May 23, 2011 at 5:33 AM, Benjamin Larsson <[email protected]> > wrote: >> On 05/21/2011 03:38 AM, Alex Converse wrote: >>> On Fri, May 20, 2011 at 7:09 AM, Benjamin Larsson <[email protected]> >>> wrote: >>>> The only thing left is the OC_GLOBAL_HDR flag that I don't get what it >>>> should be. Implicit PS and SBR should be taken care of as the >>>> CODEC_CAP_CHANNEL_CONF will always trigger a decode of the stream. >>>> >>> Seems reasonable. >>> >>> Can you test against the files in this kit: >>> http://samples.libav.org/samples/A-codecs/AAC/aacPlusDecoderCheckPackage_v2.1/ >>> and >>> http://samples.libav.org/Mpeg_Conformance/ftp.iis.fhg.de/mpeg4audio-conformance/compressedMp4/al_sbr_sig* >>> >>> If not I can test this weekend. >>> >>> Thanks, >>> Alex >> File2.mp4 sounds weird. The decoder might need some fixes. A workaround >> could be to set the parameters that util.c used to 0 if there is >> extradata. Ie something like this: >> >> if (avctx->extradata_size > 0) { >> avctx->channels = 0; >> avctx.... >> .... >> if (decode_audio_specific_config(ac, ac->avctx, &ac->m4ac, >> > Sounds weird is meaningless. The file could have sounded weird before. > The question is: 'Does the output change?' > > Based on the output with and without this patch it is clear that you > have broken implicit SBR+Implicit PS. > > Regards, > Alex
Yes, I agree. I'll fix that and resubmit tomorrow. MvH Benjamin Larsson _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
