On Wed, Jun 01, 2011 at 06:44:04AM -0700, Ronald S. Bultje wrote: > Hi, > > On Wed, Jun 1, 2011 at 6:16 AM, Diego Biurrun <[email protected]> wrote: > > On Tue, May 31, 2011 at 03:30:05PM -0700, Ronald S. Bultje wrote: > >> On Mon, May 30, 2011 at 2:07 PM, Diego Biurrun <[email protected]> wrote: > >> > > >> > --- a/libavcodec/motion_est.c > >> > +++ b/libavcodec/motion_est.c > >> > @@ -1119,8 +1119,6 @@ void ff_estimate_p_frame_motion(MpegEncContext * s, > >> > > >> > - av_dlog(s, "varc=%4d avg_var=%4d (sum=%4d) vard=%4d mx=%2d > >> > my=%2d\n", > >> > - varc, s->avg_mb_var, sum, vard, mx - xx, my - yy); > >> > >> Why does it fail to compile? Can it be fixed? > > > > Because it is infinitely broken, witness: > > > > CC libavcodec/motion_est.o > > libavcodec/motion_est.c: In function ‘ff_estimate_p_frame_motion’: > > libavcodec/motion_est.c:1125:20: error: ‘MpegEncContext’ has no member > > named ‘avg_mb_var’ > > c->mc_mb_var_sum_temp ? (suggests the code). > > > libavcodec/motion_est.c:1125:50: error: ‘xx’ undeclared (first use in this > > function) > > libavcodec/motion_est.c:1125:50: note: each undeclared identifier is > > reported only once for each function it appears in > > libavcodec/motion_est.c:1125:59: error: ‘yy’ undeclared (first use in this > > function) > > xx = mb_x * 16, yy = mb_x * 16. > > > libavcodec/motion_est.c:1125:13: warning: passing argument 2 of ‘av_log’ > > makes integer from pointer without a cast [enabled by default] > > ./libavutil/log.h:126:6: note: expected ‘int’ but argument is of type > > ‘const char *’ > > libavcodec/motion_est.c:1125:13: warning: passing argument 3 of ‘av_log’ > > makes pointer from integer without a cast [enabled by default] > > ./libavutil/log.h:126:6: note: expected ‘const char *’ but argument is of > > type ‘int’ > > make: *** [libavcodec/motion_est.o] Error 1 > > This isn't hard to fix. > > > This is a leftover from code that was removed a long time ago. > > It is not worth fixing. > > Nah... :-).
I'd say that there way not _enough_ code removed from motion_est.c, and that's worth fixing (by removing more code). _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
