On Thu, Jun 02, 2011 at 07:19:13PM -0700, Ronald S. Bultje wrote: > > --- a/libswscale/Makefile > +++ b/libswscale/Makefile > @@ -11,13 +11,14 @@ OBJS-$(ARCH_BFIN) += bfin/internal_bfin.o \ > bfin/swscale_bfin.o \ > bfin/yuv2rgb_bfin.o > OBJS-$(CONFIG_MLIB) += mlib/yuv2rgb_mlib.o > -OBJS-$(HAVE_ALTIVEC) += ppc/yuv2rgb_altivec.o > OBJS-$(HAVE_MMX) += x86/rgb2rgb.o \ > x86/yuv2rgb_mmx.o > OBJS-$(HAVE_VIS) += sparc/yuv2rgb_vis.o > > TESTPROGS = colorspace swscale > > +-include $(SUBDIR)$(ARCH)/Makefile > + > DIRS = bfin mlib ppc sparc x86 > > --- /dev/null > +++ b/libswscale/ppc/Makefile > @@ -0,0 +1,2 @@ > +OBJS-$(HAVE_ALTIVEC) += ppc/yuv2rgb_altivec.o \ > + ppc/yuv2yuv_altivec.o
I'm not a fan of split Makefiles, especially not for such small snippets. I suggest you just keep this in the main Makefile for now, splitting it can be discussed separately. > --- /dev/null > +++ b/libswscale/ppc/yuv2yuv_altivec.c > @@ -0,0 +1,191 @@ > + > +#include <inttypes.h> > +#include "config.h" > +#include "libswscale/swscale.h" > +#include "libswscale/swscale_internal.h" > +#include "libavutil/cpu.h" Just stdint.h should be enough and please separate system and local header #includes by an empty line. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
