On Sun, Jun 05, 2011 at 07:07:55PM +0200, Anton Khirnov wrote: > > On Sun, 5 Jun 2011 13:15:14 +0200, Stefano Sabatini > <[email protected]> wrote: > > On date Sunday 2011-06-05 09:07:58 +0200, Anton Khirnov encoded: > > > > > +typedef attribute_deprecated AVDictEntry AVMetadataTag; > > > > Nit: I prefer: > > > > AVDictionary -> AVDictionaryEntry > > rather than > > AVDictionary -> AVDictEntry > > > > avoiding contractions in this case allows to show better the > > relationship between the two structs, as it is done with: > > AVMetadata -> AVMetadataTag > > I disagree, IMO it's obvious how AVDictEntry relates to AVDictionary, > so you'd only annoy the devs by making them type more.
I'm with Stefano on this one and would suggest to have either AVDictionary -> AVDictionaryEntry or AVDict -> AVDictEntry Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
