Hi, On Sat, Jun 11, 2011 at 3:00 PM, Justin Ruggles <[email protected]> wrote: > On 06/10/2011 06:31 PM, Ronald S. Bultje wrote: > >> + case PIX_FMT_RGB48LE: >> + //*yuv2packed1 = yuv2rgb48le_1_c; >> + //*yuv2packed2 = yuv2rgb48le_2_c; >> + //*yuv2packedX = yuv2rgb48le_X_c; >> + //break; >> + case PIX_FMT_RGB48BE: >> + *yuv2packed1 = yuv2rgb48be_1_c; >> + *yuv2packed2 = yuv2rgb48be_2_c; >> + *yuv2packedX = yuv2rgb48be_X_c; >> + break; >> + case PIX_FMT_BGR48LE: >> + //*yuv2packed1 = yuv2bgr48le_1_c; >> + //*yuv2packed2 = yuv2bgr48le_2_c; >> + //*yuv2packedX = yuv2bgr48le_X_c; >> + //break; >> + case PIX_FMT_BGR48BE: >> + *yuv2packed1 = yuv2bgr48be_1_c; >> + *yuv2packed2 = yuv2bgr48be_2_c; >> + *yuv2packedX = yuv2bgr48be_X_c; > > > unless they are going away soon, i think those commented-out parts need > a comment there to say why.
No, the comments will go away soon once I have >8bit scaling finished. Right now, both 16bit LE and BE simply write the 8bit number in both bytes, so they're identical. With 16bit scaling, They differ in AV_WB16 vs. AV_WL16 (obviously). > besides that and my macro suggestion (take it or leave it), patch looks > ok. certainly it is much easier to understand what's going on, even if > there is some duplication. Yup will do. I'm a little slower in weekends but will apply with these changes. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
