Hi, We are using Sentry (a C/C++ static analysis tool) to analyze libav on a nightly basis. Sentry found that a dead assignment was recently introduced in the commit 50f2dfad.
I've provided a pach to remove the dead assignment of buf_size. I suggest someone first determine if the variable is actually unnecessary before removing it. Thanks, Chris -- Chris Wilson http://vigilantsw.com/ Vigilant Software, LLC --- ffserver.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/ffserver.c b/ffserver.c index 65a97b2..87894bb 100644 --- a/ffserver.c +++ b/ffserver.c @@ -2127,13 +2127,12 @@ static int open_input_stream(HTTPContext *c, const char *info) char buf[128]; char input_filename[1024]; AVFormatContext *s = NULL; - int buf_size, i, ret; + int i, ret; int64_t stream_pos; /* find file name */ if (c->stream->feed) { strcpy(input_filename, c->stream->feed->feed_filename); - buf_size = FFM_PACKET_SIZE; /* compute position (absolute time) */ if (av_find_info_tag(buf, sizeof(buf), "date", info)) { if ((ret = av_parse_time(&stream_pos, buf, 0)) < 0) @@ -2145,7 +2144,6 @@ static int open_input_stream(HTTPContext *c, const char *info) stream_pos = av_gettime() - c->stream->prebuffer * (int64_t)1000; } else { strcpy(input_filename, c->stream->feed_filename); - buf_size = 0; /* compute position (relative time) */ if (av_find_info_tag(buf, sizeof(buf), "date", info)) { if ((ret = av_parse_time(&stream_pos, buf, 1)) < 0) -- 1.6.3.3 _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
