On Thu, Jun 30, 2011 at 02:12:46PM +0200, Stefano Sabatini wrote: > On date Thursday 2011-06-30 13:37:00 +0200, Diego Biurrun encoded: > > On Thu, Jun 30, 2011 at 12:16:57AM +0100, Måns Rullgård wrote: > > > Diego Biurrun <[email protected]> writes: > > > > > > > libavutil/cpu.c:66:12: warning: too many arguments for format > > > > [-Wformat-extra-args] > > > > --- > > > > libavutil/cpu.c | 2 +- > > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/libavutil/cpu.c b/libavutil/cpu.c > > > > index ddccd00..62e485c 100644 > > > > --- a/libavutil/cpu.c > > > > +++ b/libavutil/cpu.c > > > > @@ -44,7 +44,7 @@ int main(void) > > > > int cpu_flags = av_get_cpu_flags(); > > > > > > > > printf("cpu_flags = 0x%08X\n", cpu_flags); > > > > - printf("cpu_flags = %s%s%s%s%s%s%s%s%s%s%s%s%s\n", > > > > + printf("cpu_flags = %s%s%s%s%s%s%s%s%s%s%s%s%s%s\n", > > > > #if ARCH_ARM > > > > cpu_flags & AV_CPU_FLAG_IWMMXT ? "IWMMXT " : "", > > > > #elif ARCH_PPC > > > > -- > > > > > > This is still busted on non-x86. It needs a complete rewrite. > > > > As an alternative, I could remove it - I'll send a patch for that. > > Eh? What's the point of removing everything "looks broken"?, tests are > useful both as API usage example and for testing the code (e.g. when > debugging).
I suggest you look at that program first before flaming :) That said, FFmpeg history has shown that old broken code never gets fixed anyway, it's just left to rot and rot and rot ... Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
