Hi, On Thu, Jun 30, 2011 at 10:32 AM, Jason Garrett-Glaser <[email protected]> wrote: > On Thu, Jun 30, 2011 at 10:27 AM, Ronald S. Bultje <[email protected]> wrote: >> Hi, >> >> On Wed, Jun 29, 2011 at 3:51 PM, Jason Garrett-Glaser <[email protected]> wrote: >>> --- >>> libavcodec/h264.c | 9 ---- >>> libavcodec/h264.h | 123 >>> ++++++++++++++++++++++++++--------------------- >>> libavcodec/h264_cabac.c | 21 ++++---- >>> libavcodec/h264_cavlc.c | 2 +- >>> libavcodec/svq3.c | 2 +- >>> 5 files changed, 81 insertions(+), 76 deletions(-) >> >> Unroll writing back MV, inline ff_h264_write_back_intra_pred_mode and >> cache h->xx variables, right? LGTM. >> >> Regarding write_back_intra_pred_mode(), it makes no difference since >> it's inlined anyway, but it'd be nice to keep the ff_h264 prefix >> anyway. I'll leave it up to you to ignore this or not since it's your >> patch. > > Consistency with the other write_back functions.
OK, fine with me then. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
