Hi, On Sat, Jun 18, 2011 at 5:52 AM, Anton Khirnov <[email protected]> wrote: > Adds support for decoder-private options and makes setting other options > simpler. > --- > ffprobe.c | 2 +- > ffserver.c | 2 +- > libavcodec/avcodec.h | 39 +++++++++++++++++++++++++++++++++++++++ > libavcodec/mpegvideo_enc.c | 2 +- > libavcodec/utils.c | 24 +++++++++++++++++++++++- > libavcodec/version.h | 3 +++ > libavfilter/vsrc_movie.c | 2 +- > 7 files changed, 69 insertions(+), 5 deletions(-)
This looks OK. The API makes one wonder what the utility is of AVCodecContext beyond having some read-only members for informational purposes to the user. The documentation should probably make it cear that we generally discourage using AVCodecContext to set options. Also, the documentation should mention how to find private and AVCodecContext-contained options, e.g. for encoders. But that can be done later, of course. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
