On Fri, Jul 08, 2011 at 10:25:48AM +0100, Joseph Artsimovich wrote: > Hello, > > Some time ago my company added support for 10-bit DNxHD encoding and > decoding to ffmpeg / libav. I've been trying to get this code > accepted into ffmpeg.org branch first, but this process is taking > ages. I wonder if it will get accepted here more easily. > > The patch implements both encoding and decoding for 10-bit DNxHD. > It's currently quite slow due to the lack of assembly optimizations > for 10-bit-safe DCT and IDCT code. We may be adding assembly > optimizations when we actually start working with 10-bit DNxHD > files. The color model used in 10-bit mode is YUV422P16 with 10-bit > samples scaled to 16-bit.
We have 10-bit YUV output format now, please use it. > The renaming patch is to be applied first, followed by the main one. > Both patches apply cleanly to the current libav Git head. In general code looks good to me, but tables are horrible. Can you please format them a bit (at least to fit into 80-character lines)? Another nit is context->initialized_for_bits variable name. Wouldn't output_bits suffice? Also why do you use it in some places and retrieve ctx->cid_table->bit_depth in other? Additionally, why can't you select proper transform in dsputil without overriding avctx->idct* stuff? _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
