On Thu, Jul 14, 2011 at 12:03:42PM +0200, Stefano Sabatini wrote:
> On date Thursday 2011-07-14 04:06:36 +0200, Diego Biurrun encoded:
> > 
> > --- a/libavcodec/huffman.c
> > +++ b/libavcodec/huffman.c
> > @@ -1,6 +1,4 @@
> > -/**
> > - * @file
> > - * huffman tree builder and VLC generator
> > +/*
> >   * Copyright (c) 2006 Konstantin Shishkov
> > @@ -20,6 +18,12 @@
> >  
> > +/**
> > + * @file
> > + * huffman tree builder and VLC generator
> > + * @author Konstantin Shishkov
> > + */
> 
> I'm mildly against the use of @author, authorship can be tracked more
> accurately by Git or the corresponding tool, and in many cases it ends
> up that the code written by the original author is radically modified
> by someone else (also for a more philosopically oriented perspective:
> http://video.google.nl/videoplay?docid=-4216011961522818645 - check
> "don't put names in files").

I tend to agree with you, but back in the old days I would have risked
getting flamed to a crisp for suggesting such a thing.  I'll update my
patch...

Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to