On Sat, Jul 16, 2011 at 10:25:58AM +0200, Stefano Sabatini wrote:
> 
> --- a/libavutil/fifo.h
> +++ b/libavutil/fifo.h
> @@ -106,11 +107,34 @@ int av_fifo_realloc2(AVFifoBuffer *f, unsigned int 
> size);
>  
> +/**
> + * Return a pointer to the data stored in a FIFO buffer at a certain offset.
> + * The FIFO buffer is not modified.
> + *
> + * @param f pointer to the FIFO buffer to peek at, must be non-NULL

So every caller must check for NULL?

> + * @param offs an offset in bytes, its absolute value must be less
> + * than the used buffer size or the returned pointer will point
> + * outside to the buffer data

How would the caller know the used buffer size?

Vertical alignment would help make this more readable.

Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to