On 17 August 2011 14:40, Alberto Delmás <adel...@gmail.com> wrote: > On 17/08/2011 2:08, Ronald S. Bultje wrote: >> >> I don't believe this works for negative numbers. Same for >> effects_param1/2. Probably should be abs(sd->coefs[sprite][i]) in the >> last line. > > Yeah, fixed. (Not that there should be any negative numbers in valid files > though.) > > Also simplified the vertical clipping logic and factored dst's pointer > calculation. > >> So coming back to this old one - is there some way we can signal at >> the buffer request phase which buffer is to be "displayed" and at >> display height, and which isn't? That'd allow us to keep using >> ff_thread_release_buffer() at least for these, which can be a >> significant performance gain. > > All the buffers handled in mpegvideo.c are for internal use. The ones that > are to be displayed get allocated and released in vc1_decode_sprites() using > the callbacks as normal.
The patch looks fine by me. Any other comments? _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
