On Thu, Sep 08, 2011 at 10:11:17PM +0200, Laurent Aimar wrote: > On Thu, Sep 08, 2011 at 10:05:40PM +0200, Kostya Shishkov wrote: > > On Thu, Sep 08, 2011 at 09:58:33PM +0200, Laurent Aimar wrote: > > > Hi, > > > > > > On Thu, Sep 08, 2011 at 09:54:50PM +0200, Kostya Shishkov wrote: > > > > > > It's initialised here and on error it would use random (last > > > > > > correct) value > > > > > > for it. Not that it really matters since decoding won't start > > > > > > anyway because > > > > > > of decorrelation terms not being decoded. > > > > > I can send a patch setting s->terms to 0 but it would make the case > > > > > of > > > > > WP_ID_DECTERMS a special case (other errors in WP_ID_* errors do not > > > > > reset > > > > > their associated variables). > > > > > As you prefer. > > > > > > > > Other blocks depend on this variable so it's special already. > > > If you want, patch attached. > > > > I'd say that simple one-change (assign s->terms = 0 inside condition) would > > be > > enough for this. > > I prefer consistancy and in this case it means checking size. Now if you > don't like this version, I will let you fix it as you prefer.
Good is an enemy of good enough ;). Patch is okay. And thank you for your work on fixing decoder. _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
