Diego Biurrun <di...@biurrun.de> writes:
> On Thu, Sep 22, 2011 at 12:21:27PM +0100, Måns Rullgård wrote:
>> Diego Biurrun <di...@biurrun.de> writes:
>>
>> > In case of build failures accessing these files will generate error
>> > messages
>> > that are annoying when running the FATE client through cron and add no
>> > value
>> > since the build failure implies that these files will not get created.
>> > ---
>> >
>> > --- a/tests/fate.sh
>> > +++ b/tests/fate.sh
>> > @@ -76,7 +76,8 @@ clean(){
>> > report(){
>> > date=$(date -u +%Y%m%d%H%M%S)
>> > echo "fate:0:${date}:${slot}:${version}:$1:$2:${comment}" > report
>> > - cat ${build}/config.fate ${build}/tests/data/fate/*.rep >> report
>> > + cat ${build}/config.fate >> report
>> > + cat ${build}/tests/data/fate/*.rep >> report
>> > 2> /dev/null
>> > test -n "$fate_recv" && $tar report *.log | gzip | $fate_recv
>> > }
>>
>> This is done on top of a rejected whitespace patch.
>
> And it is completely trivial to rebase on top of HEAD, since there is
> no semantic dependency on the whitespace patch.
> So please be constructive and comment on the content of the patch.
Very well then, rejected. Those error messages can in fact be useful
for trouble-shooting. If you don't want them, redirect the output in
the cron job.
--
Måns Rullgård
m...@mansr.com
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
