Hi, On Sun, Oct 16, 2011 at 10:51 PM, Anton Khirnov <[email protected]> wrote: > On Sun, 16 Oct 2011 22:09:10 -0700, "Ronald S. Bultje" <[email protected]> > wrote: >> On Sat, Oct 15, 2011 at 5:37 AM, Anton Khirnov <[email protected]> wrote: >> > It's too unreliable to be useful. avio_size() should be called instead. >> > --- >> > libavformat/aiffdec.c | 3 --- >> > libavformat/avformat.h | 4 +++- >> > libavformat/cafdec.c | 2 -- >> > libavformat/qcp.c | 3 +-- >> > libavformat/utils.c | 14 ++++++-------- >> > libavformat/version.h | 3 +++ >> > 6 files changed, 13 insertions(+), 16 deletions(-) >> >> I suppose this is OK. It would still be nice if (perhaps as part of >> avio), you could provide a static filesize so we don't have to >> seek-to-end-seek-back-to-pos if filesize _is_ static (which is mostly >> the case). Or perhaps stat(), or so... >> > > How do we know filesize is static? > > In any case, i suppose we both agree this field shouldn't be in > AVFormatContext.
Yes, as said, patch LGTM. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
