On Fri, 21 Oct 2011 16:51:33 +0300, Raivo Hool <[email protected]> wrote: > >>+ if (genre < 1 || genre > ID3v1_GENRE_MAX) genre = 1; > > >I'm not sure making up the '1' value is a good idea -- we should export > >what's stored in the file if it's valid or nothing at all. I'd just > >print a warning for invalid genre number and return. > > Okay, so what about just returning 0? If the atom is broken, nothing gets > displayed. >
Ok, all 4 pushed. There was some trailing whitespace in one of the patches. I've removed it, but please try to avoid it in the future. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
