On 10/22/2011 11:06 PM, John Stebbins wrote:
> Attempting to set ac3 dsur_mode to "on" results in:
> [AC-3 Encoder @ 0x7f508f0a3280] Value 2.000000 for parameter 'dsur_mode' out
> of range
> [AC-3 Encoder @ 0x7f508f0a3280] Error setting option dsur_mode to value on.
>
> ---
> libavcodec/ac3enc_opts_template.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/libavcodec/ac3enc_opts_template.c
> b/libavcodec/ac3enc_opts_template.c
> index acb4ab4..464e2e4 100644
> --- a/libavcodec/ac3enc_opts_template.c
> +++ b/libavcodec/ac3enc_opts_template.c
> @@ -45,7 +45,7 @@ static const AVOption eac3_options[] = {
> /* other metadata options */
> {"copyright", "Copyright Bit", OFFSET(copyright), AV_OPT_TYPE_INT, {.dbl =
> AC3ENC_OPT_NONE }, AC3ENC_OPT_NONE, 1, AC3ENC_PARAM},
> {"dialnorm", "Dialogue Level (dB)", OFFSET(dialogue_level), AV_OPT_TYPE_INT,
> {.dbl = -31 }, -31, -1, AC3ENC_PARAM},
> -{"dsur_mode", "Dolby Surround Mode", OFFSET(dolby_surround_mode),
> AV_OPT_TYPE_INT, {.dbl = AC3ENC_OPT_NONE }, AC3ENC_OPT_NONE,
> AC3ENC_OPT_MODE_OFF, AC3ENC_PARAM, "dsur_mode"},
> +{"dsur_mode", "Dolby Surround Mode", OFFSET(dolby_surround_mode),
> AV_OPT_TYPE_INT, {.dbl = AC3ENC_OPT_NONE }, AC3ENC_OPT_NONE,
> AC3ENC_OPT_MODE_ON, AC3ENC_PARAM, "dsur_mode"},
> {"notindicated", "Not Indicated (default)", 0, AV_OPT_TYPE_CONST,
> {.dbl = AC3ENC_OPT_NOT_INDICATED }, INT_MIN, INT_MAX, AC3ENC_PARAM,
> "dsur_mode"},
> {"on", "Dolby Surround Encoded", 0, AV_OPT_TYPE_CONST,
> {.dbl = AC3ENC_OPT_MODE_ON }, INT_MIN, INT_MAX, AC3ENC_PARAM,
> "dsur_mode"},
> {"off", "Not Dolby Surround Encoded", 0, AV_OPT_TYPE_CONST,
> {.dbl = AC3ENC_OPT_MODE_OFF }, INT_MIN, INT_MAX, AC3ENC_PARAM,
> "dsur_mode"},
patch is good. thank you.
I'll commit this, along with fixing the other 2 mode options that have
the same issue.
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
