On Tue, 1 Nov 2011, Martin Storsjö wrote:

On Tue, 1 Nov 2011, John Brooks wrote:

On Tue, Nov 1, 2011 at 4:43 AM, Anton Khirnov <[email protected]> wrote:

On Tue, 1 Nov 2011 12:32:15 +0200 (EET), Martin Storsjö <[email protected]> wrote:
On Tue, 1 Nov 2011, Anton Khirnov wrote:


You should be able to use the "all" named constant as default.

Hmm, av_opt_set_defaults2 only uses default_val.dbl for the default, it
doesn't try to read any string value. Since he set INT_MAX/INT_MIN as
boundaries, the user can still set that value if he wants, giving the same
effect.

Oh, right.
I should fix that.


Thanks for the comments. An updated patch with options for the RTSP
and SDP demuxers is attached; it sounds like the conclusion above was
to leave the default as-is. Is allowed_media_types an acceptable name?

The new patch looks quite ok to me, I'll still try it out a bit before applying.

It seems to work just fine for me, both for RTSP and for SDP.

A general question is whether this is the right approach to solve the issue. We've got AVStream discard flags, that convey the same thing, more or less, and these are already used to choose which streams to receive for RealRTSP. However, for that case, the rtsp demuxer would first have to configure and set up receiving all streams (since none can be set to discarded until then _open() function returns the control to the caller), and then if some of them are undesired, some of the streams could be closed (can one close and resetup streams in normal RTSP?).

Given those complications, I think this is an acceptable patch as such for now...

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to