On Thu, Nov 24, 2011 at 04:05:20PM +0100, =?UTF-8?q?Reimar=20D=C3=B6ffinger?= 
wrote:
> Not yet complete, for demuxing AAC the AAC header must be generated
> manually.
> Possibly the decoder could accept the header as extradata to simplify
> this.
> ---
> Some reformatting and checks added by me.

some nits ..

> --- /dev/null
> +++ b/libavformat/pmpdec.c
> @@ -0,0 +1,176 @@
> +/*
> + * PMP demuxer.

drop the period

> +static int pmp_probe(AVProbeData *p) {

{ on next line please, more below

> +static int pmp_header(AVFormatContext *s, AVFormatParameters *ap) {

ditto

> +static int pmp_packet(AVFormatContext *s, AVPacket *pkt) {

ditto

> +        // FIXME: this is a hack that should be remove once

removeD

> +        // compute_pkt_fields can handle

Can handle what?

> +static int pmp_seek(AVFormatContext *s, int stream_index,
> +                     int64_t ts, int flags) {

ditto and indentation is off

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to