On Sat, Nov 26, 2011 at 05:06:13PM -0500, Justin Ruggles wrote:
> Implement audio support in avcodec_default_get_buffer().
> Deprecate avcodec_decode_audio3().
> 
> Note: This patch does not work by itself. All audio decoders must be converted
> to use the new interface.
> ---
>  doc/APIchanges        |    7 ++
>  libavcodec/avcodec.h  |  125 +++++++++++++++++++++++++--
>  libavcodec/internal.h |    3 +
>  libavcodec/utils.c    |  227 ++++++++++++++++++++++++++++++++++++++++++++----
>  libavcodec/version.h  |    5 +-
>  5 files changed, 337 insertions(+), 30 deletions(-)
> 

[...]

> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 1ea96a6..8d7e8fa 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -933,10 +935,10 @@ typedef struct AVFrame {
>  #define AV_NUM_DATA_POINTERS 8
>  #endif
>      /**
> -     * pointer to the picture planes.
> +     * pointer to the picture/channel planes.
>       * This might be different from the first allocated byte
> -     * - encoding:
> -     * - decoding:
> +     * - encoding: Set by user
> +     * - decoding: set by AVCodecContext.get_buffer()
>       */
>      uint8_t *data[AV_NUM_DATA_POINTERS];
>      int linesize[4];

it wouldn't hurt to document the differences between audio and video
linesize explicitly here for another time.

otherwise looks good

Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to