On 12/12/11 09:41, Diego Biurrun wrote:
On Mon, Dec 12, 2011 at 04:23:20AM +0100, Luca Barbato wrote:
It is a slight extension of build_system.txt

End in a period.

Sure

Also, if you replace build_system.txt, your patch should delete it.

--- a/doc/Makefile
+++ b/doc/Makefile
@@ -1,7 +1,8 @@
  MANPAGES    = $(PROGS-yes:%=doc/%.1)
  PODPAGES    = $(PROGS-yes:%=doc/%.pod)
  HTMLPAGES   = $(PROGS-yes:%=doc/%.html)                                 \
-              doc/developer.html                                        \
+             doc/build_system.html                                     \
+             doc/developer.html                                        \
                doc/faq.html                                              \

Ahem ...

Those slipped... Makefile needs tabs in some places and the editor doesn't discriminate

--- /dev/null
+++ b/doc/build_system.texi
@@ -0,0 +1,63 @@
+The Libav build system is composed of a @command{bash} script,
+@command{configure}, and a number of @command{make} scripts.

It is very much not bash, but POSIX shell.  One could also argue if
Makefiles are really separate given that they are snippets that get
assembled into one big Makefile at runtime.

switched to posix, the part about makefile might enjoy a better wording and I'd let others propose it later.

+@command{configure} generates @code{config.mak}, @code{config.h}, and
+the @command{pkg-config} files.
+Then it is possible to build and install Libav by running @command{make}

End in a period.

Right

Please consistently end in periods or don't capitalize if the
descriptions are not complete sentences.

Added the periods, not sure about not capitalizing.

You could add an entry for fate.

Not sure if is better linking the fate page or reporting there the same information.

lu

--

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to