On Mon, Dec 12, 2011 at 10:00:24PM +0100, Luca Barbato wrote:
> On 12/12/11 21:48, Diego Biurrun wrote:
> >On Thu, Nov 03, 2011 at 05:26:08PM -0400, Justin Ruggles wrote:
> >>On 11/03/2011 05:03 PM, Diego Biurrun wrote:
> >>>
> >>>--- a/libavformat/mov.c
> >>>+++ b/libavformat/mov.c
> >>>@@ -127,8 +127,8 @@ static int mov_metadata_int8_no_padding(MOVContext *c,
> >>>AVIOContext *pb,
> >>>
> >>>-static int mov_metadata_gnre(MOVContext *c, AVIOContext *pb,
> >>>- unsigned len, const char *key)
> >>>+static int mov_metadata_genre(MOVContext *c, AVIOContext *pb,
> >>>+ unsigned len, const char *key)
> >>> {
> >>>@@ -206,7 +206,7 @@ static int mov_read_udta_string(MOVContext *c,
> >>>AVIOContext *pb, MOVAtom atom)
> >>> case MKTAG(0xa9,'g','e','n'): key = "genre"; break;
> >>> case MKTAG( 'g','n','r','e'): key = "genre";
> >>>- parse = mov_metadata_gnre; break;
> >>>+ parse = mov_metadata_genre; break;
> >>> case MKTAG(0xa9,'t','o','o'):
> >>> case MKTAG(0xa9,'s','w','r'): key = "encoder"; break;
> >>
> >>
> >>that's not a typo, it's the tag name. either way is ok though i suppose.
> >
> >Somebody please decide what the preferred way shall be then.
>
> The atom name probably is better.
OK, patch dropped.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
