Hi, will address the comments in a new patch. To answer the questions:
2011/12/12 Måns Rullgård <[email protected]> > "Ronald S. Bultje" <[email protected]> writes: > > @@ -971,6 +972,7 @@ CONFIG_LIST=" > > rdft > > rtpdec > > runtime_cpudetect > > + safe_bitstream_reader > > shared > > sinewin > > small > > If the idea is to have this on by default, you need an > "enable safe_bitstream_reader" line somewhere before the flags are parsed. > I wanted to keep it off by default until we have a good idea on performance impact. > --- a/libavcodec/wmavoice.c > > +++ b/libavcodec/wmavoice.c > > @@ -25,6 +25,8 @@ > > * @author Ronald S. Bultje <[email protected]> > > */ > > > > +#define UNCHECKED_BITSTREAM_READER 1 > > Is this the only safe decoder? > No, it's just intended as an example. I believe we have a handful of actually safe decoders. I don't know which they are tbh. Ronald
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
