Is this what you meant by :- > This is admittedly slightly tricky because of the #ifdef, but there > are 4 spaces too much indentation in the second and third line.
Secondly, I wanted to deliver that i am trying my level best to get what you suggest and implement them, and i rechecked that file 2-3 times now, I think the other comments were implemented already (in the whole patch) and you can check it once more. Thanks Aneesh Dogra --- libavcodec/mpegvideo_enc.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 356087e..c3fc225 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -90,9 +90,9 @@ void ff_convert_matrix(DSPContext *dsp, int (*qmat)[64], } } else if (dsp->fdct == fdct_ifast #ifndef FAAN_POSTSCALE - || dsp->fdct == ff_faandct + || dsp->fdct == ff_faandct #endif - ) { + ) { for (i = 0; i < 64; i++) { const int j = dsp->idct_permutation[i]; /* 16 <= qscale * quant_matrix[i] <= 7905 */ @@ -125,9 +125,9 @@ void ff_convert_matrix(DSPContext *dsp, int (*qmat)[64], int64_t max = 8191; if (dsp->fdct == fdct_ifast #ifndef FAAN_POSTSCALE - || dsp->fdct == ff_faandct + || dsp->fdct == ff_faandct #endif - ) { + ) { max = (8191LL * ff_aanscales[i]) >> 14; } while (((max * qmat[qscale][i]) >> shift) > INT_MAX) { -- 1.7.4.1 _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel