Hi, On Tue, Dec 27, 2011 at 8:51 AM, Diego Biurrun <di...@biurrun.de> wrote: > On Tue, Dec 27, 2011 at 11:38:07AM +0530, Aneesh Dogra wrote: >> >> --- a/libavcodec/mpegvideo_enc.c >> +++ b/libavcodec/mpegvideo_enc.c >> @@ -59,157 +59,191 @@ static int dct_quantize_trellis_c(MpegEncContext *s, >> DCTELEM *block, int n, int >> >> - const int j= dsp->idct_permutation[i]; >> - /* 16 <= qscale * quant_matrix[i] <= 7905 */ >> - /* 19952 <= ff_aanscales[i] * qscale * >> quant_matrix[i] <= 249205026 */ >> - /* (1 << 36) / 19952 >= (1 << 36) / (ff_aanscales[i] * >> qscale * quant_matrix[i]) >= (1 << 36) / 249205026 */ >> - /* 3444240 >= (1 << 36) / (ff_aanscales[i] * >> qscale * quant_matrix[i]) >= 275 */ >> + const int j = dsp->idct_permutation[i]; >> + /* 16 <= qscale * quant_matrix[i] <= 7905 >> + * Assume x = ff_aanscales[i] * qscale * quant_matrix[i] >> + * 19952 <= x <= 249205026 >> + * (1 << 36) / 19952 >= (1 << 36) / (x) >= (1 << 36) / >> + * 249205026 >> + * 3444240 >= (1 << 36) / (x) >= 275 */ > > WTF are you doing here?
That's a very unhelpful comment. The comment before is unreadable long. Ronald _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
