On Fri, Dec 30, 2011 at 08:33:11PM +0100, Kostya Shishkov wrote: > On Fri, Dec 30, 2011 at 07:11:32PM +0000, Måns Rullgård wrote: > > Kostya Shishkov <[email protected]> writes: > > > > > On Fri, Dec 30, 2011 at 07:01:18PM +0000, Måns Rullgård wrote: > > >> Diego Biurrun <[email protected]> writes: > > >> > > >> > --- > > >> > tools/qt-faststart.c | 90 > > >> > +++++++++++++++++++++++++------------------------- > > >> > 1 files changed, 45 insertions(+), 45 deletions(-) > > >> > > > >> > -#define BE_16(x) ((((uint8_t*)(x))[0] << 8) | ((uint8_t*)(x))[1]) > > >> > > >> Macros with this functionality are available in lavu, or is qt-faststart > > >> not supposed to use that for some reason? > > > > > > it's supposed to be completely standalone tool, so no lav* dependencies > > > > Why? > > Because it's useful on its own (not only in connection with libav*) > and it's easy to compile even without our build system.
It's not easy to compile without our build system apparently, just see the comments at the top of the file. Whether or not that warrants ripping out the code duplication and making it depend on lavu I have no opinion on. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
